Back to the main page.

Bug 1919 - merge planarchannelset with ft_senslabel

Status CLOSED FIXED
Reported 2013-01-07 15:30:00 +0100
Modified 2014-02-24 10:56:40 +0100
Product: FieldTrip
Component: core
Version: unspecified
Hardware: PC
Operating System: Mac OS
Importance: P3 normal
Assigned to: Robert Oostenveld
URL:
Tags:
Depends on:
Blocks:
See also:

Robert Oostenveld - 2013-01-07 15:30:27 +0100

ft_senslabel returns lists of channels. ft_channelselection also has lists of channels internally, e.g. 'eog' and 'eegref' private/planarchannelset also defines lists. These functionalities should be merged into ft_senslabel, planarchannelset should go, and ft_channelselection should not define its own lists. This requires that ft_senslabel is extended like ft_senslabel('ctf151_planar') -> returns cell(302,1) ft_senslabel('ctf151_planar', 'pair', yes) -> returns cell(151,2) ft_senslabel('neuromag306', 'pair', yes) -> returns cell(102,3) ft_senslabel('ctf151_planar', 'combined', yes/no) -> returns cell(151,1) with combined labels ft_senslabel('neuromag306', 'combined', yes/no) -> returns cell(102,1) with combined labels default is pair = no, combined=no. the combination pair=yes && combined=no should not be supported. Or perhaps better something like ft_senslabel(type, 'format', xxx) where xxx is list (default), paired, combined.


Vladimir Litvak - 2013-01-07 15:39:06 +0100

(In reply to comment #0) OK then to get the present functionality of ft_planarchanset one would have to do something like: ft_senslabel(ft_senstype(input), 'format', 'paired') That could be done in SPM code if you want. Regarding ft_senstype, it's I think just a historical (and aesthetic) thing that it's not called ft_channelsettype. In any case I think it would be useful also in FT to have a function that can identify that some raw or timelock struct contains data from combined planar channels. Also by your logic if ft_senstype is the inverse of ft_senslabel it should be able to recognize also paired and combined lists.


Robert Oostenveld - 2013-11-18 10:41:06 +0100

mac001> svn commit test/test_bug1919.m ft_prepare_layout.m ft_combineplanar.m forward/ft_senslabel.m Sending forward/ft_senslabel.m Sending ft_combineplanar.m Sending ft_prepare_layout.m Adding test/test_bug1919.m Transmitting file data .... Committed revision 8796.


Robert Oostenveld - 2014-02-24 10:56:40 +0100

I closed several bugs at once that all have been resolved for some time. If you disagree, please reopen.