Back to the main page.
Bug 1129 - implement firls filter and change default order of fir1 to 200
| Status | CLOSED FIXED |
| Reported | 2011-11-09 10:59:00 +0100 |
| Modified | 2011-12-15 09:23:49 +0100 |
| Product: | FieldTrip |
| Component: | core |
| Version: | unspecified |
| Hardware: | PC |
| Operating System: | Windows |
| Importance: | P1 normal |
| Assigned to: | Johanna |
| URL: | |
| Tags: | |
| Depends on: | |
| Blocks: | |
| See also: |
Johanna - 2011-11-09 10:59:49 +0100
I realise firls may need stats toolbox, but may be worth it to include if user has this toolbox and wants this option? also, fir1 (included) has default order 25, but higher order (bijvoorbeeld 200) is better if enough data points. suggest to increase default order.
Johanna - 2011-11-09 12:09:18 +0100
Created attachment 182 screenshot filter results
Johanna - 2011-11-09 12:31:43 +0100
Created attachment 183 code to generate figures in first attachment screenshot.
Johanna - 2011-11-09 12:36:23 +0100
Created attachment 184 instead, using 2-6hz frequency rather than 15-25hz
Johanna - 2011-11-14 12:43:24 +0100
default filter order for 'fir' (fir1) changed to depend on data (size and Fs) plus filter request. Butterworth unchanged. Default filter order is now set in low-level function (depending on filter type), rather than in preproc.
Johanna - 2011-11-14 14:35:19 +0100
'firls' added for bp, hp, lp. NM doesn't use it for bandstop, so not sure at the moment how to add that.