Back to the main page.

Bug 312 - statistics_* should be ft-prefixed

Reported 2010-12-15 14:01:00 +0100
Modified 2013-01-17 10:46:14 +0100
Product: FieldTrip
Component: core
Version: unspecified
Hardware: PC
Operating System: All
Importance: P1 enhancement
Assigned to: Roemer van der Meij
Depends on:
See also:

Robert Oostenveld - 2010-12-15 14:01:17 +0100

Roemer van der Meij - 2012-03-20 17:39:19 +0100

Functions that should be ft_ prefixed: statistics_analytic.m statistics_crossvalidate.m statistics_montecarlo.m statistics_stats.m statistics_wrapper.m

Roemer van der Meij - 2012-03-20 17:45:54 +0100

Doing a grep on statistics_analytic, _stats, and _crossvalidate, only returned code from the functions themselves. Robert, are these functions no longer in use? Or maybe my grep was wrong(?) grep 'statistics_crossvalidate' *.m */*.m */*/*.m

Roemer van der Meij - 2012-03-21 11:20:52 +0100

I guess I was sleeping yesterday, the grep should be like of course: grep 'statistics_stats' *.m ./*/*.m ./*/*/*.m ./*/*/*/*.m no other references to these functions in the tree though. Will ask at meeting.

Jan-Mathijs Schoffelen - 2012-03-21 13:50:03 +0100

ft_XXXstatistics creates a function handle on the fly, using cfg.method sprintf('statistics_%s',cfg.method) -> replace with sprintf('ft_statistics_%s',cfg.method), and changing the file names should do the trick

Roemer van der Meij - 2012-03-23 13:30:22 +0100

(note to self) These functions contain all references to the statistics functions. grep -l 'statistics_' *.m ./*/*.m ./*/*/*.m ./*/*/*/*.m ft_freqstatistics.m ft_sourcestatistics.m ft_timelockstatistics.m statistics_analytic.m statistics_crossvalidate.m statistics_montecarlo.m statistics_stats.m ./private/clusterstat.m ./private/statistics_wrapper.m

Roemer van der Meij - 2012-04-18 16:02:12 +0200

Prefixed! Tested for ft_timelockstatistics and ft_freqstatistics for montecarlo, analytic and stats. Ft_so-urcestatistics didn't have a test script yet, so that remains untested. However, changes to it were identical to freq/timelock, and it depends on the same lower level statistics_XXX functions, so it should be fine.

Roemer van der Meij - 2013-01-17 10:46:14 +0100

bug closing time