Back to the main page.

Bug 2981 - duplicate code: ft_statfun_depsamplesF.m and ft_statfun_depsamplesFmultivariate.m

Reported 2015-10-06 16:54:00 +0200
Modified 2019-08-10 12:31:28 +0200
Product: FieldTrip
Component: core
Version: unspecified
Hardware: All
Operating System: All
Importance: P5 minor
Assigned to: Johanna
Depends on:
See also:

Johanna - 2015-10-06 16:54:14 +0200

Hi all, Both ft_statfun_depsamplesF.m and ft_statfun_depsamplesFmultivariate.m exist, but are identical aside from in name. If both names are desired to be kept around (e.g. for legacy), then one function should simply call the other. There is danger that someone could edit one and not the other. Which one should be the 'main' one and which one removed? My guess is ft_statfun_depsamplesFmultivariate.m should be kept, to complement ft_statfun_depsamplesFunivariate.m. Cheers, Johanna

Diego Lozano Soldevilla - 2015-10-06 17:04:43 +0200

(In reply to Johanna from comment #0) Hi Johanna, You can safely remove ft_statfun_depsamplesF function. I created the ft_statfun_depsamplesFunivariate and I forgot to delete the 'old' ft_statfun_depsamplesF (multivariate) best Diego

Johanna - 2015-10-06 17:10:17 +0200

Done. zumerj@psychl-132432-1:/mnt/hgfs/D/fieldtrip_svn/statfun$ svn delete ft_statfun_depsamplesF.m D ft_statfun_depsamplesF.m zumerj@psychl-132432-1:/mnt/hgfs/D/fieldtrip_svn/statfun$ svn commit ft_statfun_depsamplesF.m Deleting ft_statfun_depsamplesF.m Committed revision 10746.

Diego Lozano Soldevilla - 2015-10-06 17:12:00 +0200

(In reply to Johanna from comment #2) thanks Johanna!

Robert Oostenveld - 2019-08-10 12:31:28 +0200

This closes a whole series of bugs that have been resolved (either FIXED/WONTFIX/INVALID) for quite some time. If you disagree, please file a new issue on