Back to the main page.

Bug 214 - the fieldtrip/private/triplot function is deprecated and should be replaced by ft_plot_mesh

Reported 2010-11-11 16:34:00 +0100
Modified 2013-01-17 10:46:24 +0100
Product: FieldTrip
Component: plotting
Version: unspecified
Hardware: PC
Operating System: Mac OS
Importance: P1 normal
Assigned to: Roemer van der Meij
Depends on:
See also:

Robert Oostenveld - 2010-11-11 16:34:26 +0100

triplot is an old function of me that is in fieldtrip/private, but which we should try to get rid of in favour of the new plotting functions. It is still being used in manzana> grep -l triplot *.m ft_electroderealign.m ft_headmodelplot.m ft_interactiverealign.m ft_megrealign.m Please replace it by ft_plot_mesh, keeping the functional behavior (color etc.) the same. The functions should be tested with the new plot function prior to committing.

Robert Oostenveld - 2011-01-16 22:50:45 +0100

changed the status for all ASSIGNED bugs to joint development user (fieldtrip-bugs) to status NEW, otherwise we don't see the in the Wednesday meetings.

Stephen Whitmarsh - 2011-04-06 11:53:26 +0200

ah.. half way there...

Stephen Whitmarsh - 2011-07-27 11:23:45 +0200

To be able to test and debug needs a BEM volume, and a headshape. (Which raises the question: have we figured out a consistent nomenclature regarding .headshape/.vol yet?)

Stephen Whitmarsh - 2011-11-29 13:15:02 +0100

ft_headmodelplot = deprecated, so wont fix. ft_megrealign: do not understand functionality (third argument in triplot) ft_interactiverealign: needs funtionality of plot_mesh to plot 'nodes', i.e. electrodes. ft_prepare_headmodel: uses triplot in some testcode (?) at the EOF: if 0 % this is some test/demo code [pnt, tri] = icosahedron162; scale = 1+0.3*randn(size(pnt,1),1); pnt = pnt .* [scale scale scale]; figure triplot(pnt, tri, [], 'faces') triplot(pnt, tri, [], 'edges') [pnt, tri] = fairsurface(pnt, tri, 10); figure triplot(pnt, tri, [], 'faces') triplot(pnt, tri, [], 'edges') end

Jan-Mathijs Schoffelen - 2012-03-07 13:36:10 +0100

present from Roemer to Stephen

Roemer van der Meij - 2012-04-18 17:27:34 +0200

Note: ft_electroderealign.m - done ft_headmodelplot.m - ... ft_interactiverealign.m - ... ft_megrealign.m - ...

Roemer van der Meij - 2012-08-03 15:15:08 +0200

Note to self: /private/prepare_mesh_headshape also uses triplot So: ft_electroderealign.m - done ft_headmodelplot.m - deprecated (won't fix) ft_interactiverealign.m - ... ft_megrealign.m - ... ft_prepare_headmodel.m - ... (test-code)

Roemer van der Meij - 2012-08-03 18:03:43 +0200

ft_electroderealign.m - done ft_headmodelplot.m - deprecated (won't fix) ft_interactiverealign.m - done ft_megrealign.m - done ft_prepare_headmodel.m - done /private/prepare_mesh_headshape.m - done All calls to triplot.m have been changed to equivalent calls to ft_plot_mesh (and tested). Triplot.m has been moved to compat.

Roemer van der Meij - 2013-01-17 10:46:24 +0100

bug closing time