Back to the main page.

Bug 1999 - merge svn testing and benchmark directory with fieldtrip/test

Reported 2013-02-20 14:19:00 +0100
Modified 2019-08-10 12:37:26 +0200
Product: FieldTrip
Component: test
Version: unspecified
Hardware: PC
Operating System: Mac OS
Importance: P3 normal
Assigned to: Robert Oostenveld
Depends on:
See also:

Jan-Mathijs Schoffelen - 2013-02-20 14:19:39 +0100

once upon a time, there was a branch in svn called testing. There are still some test scripts in there, these can probably be moved/merged with their pals in fieldtrip/test

Robert Oostenveld - 2014-02-24 11:06:51 +0100


Robert Oostenveld - 2014-02-24 11:22:49 +0100

I also came across the benchmark branch. I believe it is one that I created at the start of the BrainGain project, to ensure that the preproc functions were fast enough (or at least not getting slower). on the fieldtrip wiki I found a reference to r566 that had to do with this. I don't want to continue the benchmarking branch, but we can reuse the scripts as test script. I renamed them from benchmark_bandpassfilter.m to test_benchmark_ft_bandpassfilter.m etc.

Robert Oostenveld - 2014-02-24 11:28:39 +0100

when running the "new" test scripts, I found that ft_preproc_detrend was documented as ft_preproc_detrend(dat, begsample, endsample, order) but implemented as ft_preproc_detrend(dat, begsample, endsample) I have fixed this in the documentation. mbp> svn commit preproc/ Sending preproc/ft_preproc_baselinecorrect.m Sending preproc/ft_preproc_detrend.m Sending preproc/ft_preproc_polyremoval.m Transmitting file data ... Committed revision 9234.

Robert Oostenveld - 2014-02-24 11:44:45 +0100

I added the benchmarking test scripts to the present fieldtrip/test directory mbp> svn commit Adding test/private/benchmark.m Adding test/test_benchmark_ft_bandpassfilter.m Adding test/test_benchmark_ft_bandstopfilter.m Adding test/test_benchmark_ft_baselinecorrect.m Adding test/test_benchmark_ft_derivative.m Adding test/test_benchmark_ft_detrend.m Adding test/test_benchmark_ft_dftfilter.m Adding test/test_benchmark_ft_highpassfilter.m Adding test/test_benchmark_ft_hilbert.m Adding test/test_benchmark_ft_lowpassfilter.m Adding test/test_benchmark_ft_medianfilter.m Adding test/test_benchmark_ft_rectify.m Adding test/test_benchmark_ft_rereference.m Adding test/test_benchmark_ft_standardize.m Transmitting file data .............. Committed revision 9238.

Robert Oostenveld - 2014-02-24 11:46:50 +0100

(In reply to Robert Oostenveld from comment #4) I also removed the branch from the main svn mbp> svn commit benchmarking/ Deleting benchmarking Committed revision 9239.

Robert Oostenveld - 2014-02-24 11:59:45 +0100

mbp> svn commit test_old_*m -m "restructuring - added test scripts from the old svn testing branch, see" Adding test_old_appenddata_2datasets.m Adding test_old_besa2fieldtrip.m Adding test_old_buffer_latency_bandwidth.m Adding test_old_connectivityanalysis.m Adding test_old_connectivityanalysis_sourcedata.m Adding test_old_filtering.m Adding test_old_fixcsd.m Adding test_old_fixsource.m Adding test_old_ft_freqanalysis.m Adding test_old_ft_multiplotER.m Adding test_old_ft_singleplotER.m Adding test_old_ft_singleplotTFR.m Adding test_old_ft_sourceanalysis_lcmv.m Adding test_old_ft_topoplotTFR.m Adding test_old_ft_write_volume.m Adding test_old_halfspace_bug243.m Adding test_old_preproc_resample.m Adding test_old_source2sparse.m Adding test_old_sourcestatistics.m Adding test_old_specest_vs_oldimplementation.m Adding test_old_spm8.m Adding test_old_trialdef.m Transmitting file data ...................... Committed revision 9240. mbp> svn commit testing -m "restructuring - removed old testing branch, the code is now in fieldtrip/test. See" Deleting testing Committed revision 9241. I have not yet tested the new "old" test scripts: I noticed that some of them require input data from home/common, which I don't have here at the moment. I'll let the dashboard run them first.

Robert Oostenveld - 2018-10-31 20:41:14 +0100

all test scripts have been merged into fieldtrip/test (some in plotting/test and spike/test) and moved over to github.

Robert Oostenveld - 2019-08-10 12:37:26 +0200

This closes a whole series of bugs that have been resolved (either FIXED/WONTFIX/INVALID) for quite some time. If you disagree, please file a new issue on