Back to the main page.

Bug 1602 - ft_selectdata_new has a few simple bugs that crash on freq data

Reported 2012-07-06 23:07:00 +0200
Modified 2012-08-23 10:47:57 +0200
Product: FieldTrip
Component: core
Version: unspecified
Hardware: Macintosh
Operating System: Mac OS
Importance: P3 normal
Assigned to: Jan-Mathijs Schoffelen
Depends on:
See also:

Matt Mollison - 2012-07-06 23:07:38 +0200

fieldtrip-20120706 In ft_selectdata_new there is a for loop at line 419 (for i=1:numel(varargin)) that shouldn't be there. There is no varargin in the internal function getselection_freq(). two more things: line 420 asks: if numel(cfg.latency)==1 it should ask about cfg.frequency line 435 sets cfg.latency = data.freq([fbeg fend]);, when it should be setting cfg.frequency.

Matt Mollison - 2012-07-06 23:14:32 +0200

Also, there are a bunch of keyboard commands. I guess this isn't ready for prime time and I should stick with ft_selectdata_old. Sorry if this is bringing up known issues.

Jan-Mathijs Schoffelen - 2012-07-07 19:15:45 +0200

Hi Matt, Thanks for reporting this. I just pushed the changes to the repository (revision 6244). Could I ask you to test if it now works with this version? Thanks, JM

Matt Mollison - 2012-07-09 23:38:41 +0200

The bugs seem fixed. However, with freq data it still hits the keyboard command on line 202 (which is understandable because it seems like there's still a lot more to implement).

Jan-Mathijs Schoffelen - 2012-07-10 08:34:46 +0200

Hi Matt, Thanks. Yeah, you have two options here: either use ft_selectdata_old, or keep feeding us with patches to ft_selectdata_new, so that eventually this guy will work, too. ;-) Apparently the team needs some extrinsic motivation to push this one into functionality...