Back to the main page.

Bug 1184 - ft_timelockgrandaverage cannot handle variables that lack an 'avg' field

Reported 2011-11-25 14:36:00 +0100
Modified 2019-08-10 11:56:25 +0200
Product: FieldTrip
Component: core
Version: unspecified
Hardware: PC
Operating System: Windows
Importance: P4 enhancement
Assigned to: Arjen Stolk
Depends on:
See also:

Arjen Stolk - 2011-11-25 14:36:39 +0100

For instance, when one performs timelockstatistics at the subject-level and wants to grandaverage all the stats. The input variable to ft_timelockgrandaverage lacks an 'avg' field, which ft_timelockgrandaverage desperately wants. Desired outcome: make ft_timelockgrandaverage deal with 'stat' field.

Boris Reuderink - 2011-11-28 14:34:14 +0100

Defect by developer. Sounds reasonable to me. Changed status to NEW.

Jan-Mathijs Schoffelen - 2011-12-07 14:08:24 +0100

make an inventory of the functions which make hard-coded assumptions regarding the fieldname containing the numerical data. as an example fix look at ft_freqgrandaverage or ft_freqstatistics which uses cfg.parameter and don't forget to make a test script.

Arjen Stolk - 2012-07-25 11:17:30 +0200

Working on it right now. Making ft_timelockgrandaverage to follow the outline of ft_freqgrandaverage.

Arjen Stolk - 2012-07-25 22:31:05 +0200

ft_timelockgrandaverage now follows outline ft_freqgrandaverage. implemented support for cfg.parameter, although 1 input parameter at a time (because the output is either 'avg' or 'invididual' and to avoid any nestings). furthermore, the new implementation supports different (average) triallengths per subjects

Arjen Stolk - 2012-07-25 22:31:34 +0200

Btw, there's now also a test_ft_timelockgrandaverage.

Robert Oostenveld - 2019-08-10 11:56:25 +0200

This closes a whole series of bugs that have been resolved (either FIXED/WONTFIX/INVALID) for quite some time. If you disagree, please file a new issue describing the issue on